Conversation
… matching (=~)
There was a problem hiding this comment.
Pull request overview
This PR modernizes the jsonpath-python project with a comprehensive infrastructure overhaul and important feature additions. The changes migrate from legacy setup.py to modern pyproject.toml, introduce a new update() method for modifying JSON data, and fix multiple reported bugs in path handling, filtering, and sorting operations.
Key Changes
- Infrastructure: Migration to
pyproject.tomlwithuvpackage manager, addition of CI/CD workflows, and test directory reorganization - New Feature:
JSONPath.update()method for in-place JSON modification with support for both static values and callback functions - Bug Fixes: Fixed path output format, filter expression handling with bracket notation and quoted keys, field extractor null filtering, and mixed-type sorting errors
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Dependency lockfile with multiple package versions (contains future-dated version references that need verification) |
| pyproject.toml | Modern Python project configuration with build system, dependencies, and development tools |
| tests/test_update.py | Comprehensive test suite for the new update() functionality |
| tests/test_issues.py | Test cases validating bug fixes for issues #9, #10, #13, #15, #16, #17 |
| tests/test_jsonpath.py | Simplified existing test structure |
| tests/conftest.py | Updated test fixtures with corrected path format expectations |
| tests/data/*.json | Test data files relocated to tests directory |
| jsonpath/init.py | Simplified module interface with clean imports |
| jsonpath/jsonpath.py | Core implementation with update() method, path format changes, and bug fixes |
| setup.py | Removed in favor of pyproject.toml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR modernizes the jsonpath-python project with significant improvements to infrastructure, features, and bug fixes.
Major Changes
🏗️ Infrastructure Modernization
setup.pytopyproject.tomlwithuvpackage managersemantic-releasefor automated versioning and changelog generationrufffor code qualitytest/→tests/)✨ New Features
JSONPath.update()method to modify JSON data using JSONPath expressionsinoperator and regex matching (=~) in filter expressions🐛 Bug Fixes
JSONPathTypeErroron mixed type sorting attempts📚 Documentation
Breaking Changes
None - This is backward compatible.
Testing