Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDP Mode: Patch 63
--> This resolves Add command-line shortcuts for Pure CDP Mode (
sb_cdp) #4008--> May improve clicking of
<div>and<input>elements--> This resolves Make
PyAutoGUIa required dependency on Linux #4009For Pure CDP Mode (
sb_cdp), we're adding the ability to set options via command-line args. Here's what to expect, with examples:There are a few additional options on Linux, such as --gui/--headed, (which overrides the default Linux headless mode).
And there's --xvfb on Linux for the special virtual display (which may already be set by default if not using other options).
This aims to simplify option-handling, as you will no longer need to modify a script itself in order to change how it runs.
Note that all these options were already available via method args passed into
sb_cdp.Chrome(). Method args always take priority over command-line options. For example, if you set thebinary_location/browser_executable_pathvia method arg, but set a different one on the command-line, then the method arg takes priority.