Restore attachTo tabindex when tour is hidden#3351
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe changes implement tabindex preservation for Shepherd.js tour steps. When a step attaches to an element and forces it focusable by setting tabIndex to 0, the original tabindex value is stored. Upon step hide or destruction, the original tabindex is restored (or the attribute is removed if none previously existed). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🛟 Help
|

Fixes #3334
Summary by CodeRabbit
Release Notes