Fix enable_fts() when FTS table already exists without replace=True#709
Open
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
Open
Fix enable_fts() when FTS table already exists without replace=True#709RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
Conversation
When calling enable_fts() on a table that already has an FTS index, without passing replace=True, the function now returns early instead of attempting to create the table again and raising an error. Fixes simonw#694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
enable_fts()on a table that already has an FTS index, without passingreplace=True, the function now returns early instead of attempting to create the table again and raising ansqlite3.OperationalError: table '{}_fts' already existserror.Changes
enable_fts()to return early if FTS table exists andreplace=False(the default)test_enable_fts_twice_without_replace()Fixes #694
📚 Documentation preview 📚: https://sqlite-utils--709.org.readthedocs.build/en/709/