Fix: CSV insert with --detect-types crashes on header-only CSV#710
Open
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
Open
Fix: CSV insert with --detect-types crashes on header-only CSV#710RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
RamiNoodle733 wants to merge 1 commit intosimonw:mainfrom
Conversation
When using --detect-types with a CSV file containing only a header row (and no data rows), the insert would fail with 'Cannot transform a table that doesn't exist yet' because the table is only created when rows are inserted. This fix adds an existence check before attempting to transform. Fixes simonw#702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
sqlite-utils insertwith--detect-typesflag on a CSV file containing only a header row (no data), the command crashes with:Root Cause
The
transform()method was being called to apply detected types to the table, but when there are no data rows, the table is never created.Fix
Added existence checks before calling
transform()in two locations incli.py.Testing
Added
test_insert_csv_header_only()to verify the fix.Fixes #702
📚 Documentation preview 📚: https://sqlite-utils--710.org.readthedocs.build/en/710/