-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(terminal): subflow logs rendering #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR fixes subflow log rendering by threading a stable subflow identifier ( It also tightens console update targeting by allowing Key areas touched:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Exec as BlockExecutor
participant SSE as createSSECallbacks
participant API as /api/workflows/[id]/execute (SSE)
participant UI as useWorkflowExecution
participant Store as TerminalConsoleStore
participant Term as Terminal buildEntryTree
Exec->>SSE: onBlockStart(blockId,..., executionOrder, IterationContext)
SSE->>API: sendEvent block:started {iterationContainerId}
API->>UI: SSE message block:started
UI->>Store: addConsole/updateConsole (executionOrder, iterationContainerId)
Store->>Term: groupEntriesByExecution -> buildEntryTree
Term-->>UI: Render subflow/iteration grouping by (iterationType, iterationContainerId, iterationCurrent)
Exec->>SSE: onBlockComplete(..., callbackData, IterationContext)
SSE->>API: sendEvent block:completed|block:error {iterationContainerId}
API->>UI: SSE message block:completed|block:error
UI->>Store: updateConsole (matches by blockId+executionId+executionOrder+iteration*)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 3 comments
Additional Comments (1)
The new Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
Summary
Subflow logs rendering should be accurate.
Type of Change
Testing
Tested manually
Checklist