fix(variables): fix tag dropdown and cursor alignment in variables block#3199
fix(variables): fix tag dropdown and cursor alignment in variables block#3199waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryFixed tag dropdown behavior and cursor alignment issues in variables block by renaming dropdown header to match tag prefix and migrating array/object fields to Code editor. Key changes:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant VariablesInput
participant CodeEditor
participant TagDropdown
User->>VariablesInput: Type in array/object field
VariablesInput->>CodeEditor: getEditorValueChangeHandler(assignmentId)
CodeEditor->>CodeEditor: onChange triggered
CodeEditor->>VariablesInput: newValue passed to handler
VariablesInput->>VariablesInput: updateAssignmentRef.current(id, {value})
VariablesInput->>CodeEditor: Query textarea for cursor position
CodeEditor-->>VariablesInput: selectionStart position
VariablesInput->>VariablesInput: checkTagTrigger(newValue, pos)
alt Tag trigger detected
VariablesInput->>TagDropdown: setShowTags(true) with textarea ref
TagDropdown-->>User: Display tag suggestions
User->>TagDropdown: Select tag
TagDropdown->>VariablesInput: handleTagSelect(tag)
VariablesInput->>CodeEditor: Insert tag at cursor position
end
User->>CodeEditor: Drag tag into field
CodeEditor->>VariablesInput: onDrop event
VariablesInput->>VariablesInput: handleEditorDrop(e, assignmentId)
VariablesInput->>CodeEditor: Insert '<' and set cursor
VariablesInput->>TagDropdown: setShowTags(true)
TagDropdown-->>User: Display tag suggestions
|
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
Additional Comments (1)
|
|
@cursor review |
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
|
@greptile |
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
|
@cursor review |
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
.../panel/components/editor/components/sub-block/components/variables-input/variables-input.tsx
Outdated
Show resolved
Hide resolved
1e8855e to
13eff44
Compare
) * fix(terminal): reconnect to running executions after page refresh * fix(terminal): use ExecutionEvent type instead of any in reconnection stream * fix(execution): type event buffer with ExecutionEvent instead of Record<string, unknown> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(execution): validate fromEventId query param in reconnection endpoint Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix some bugs * fix(variables): fix tag dropdown and cursor alignment in variables block (#3199) * feat(confluence): added list space labels, delete label, delete page prop (#3201) * updated route * ack comments * fix(execution): reset execution state in reconnection cleanup to unblock re-entry Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(execution): restore running entries when reconnection is interrupted by navigation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * done * remove cast in ioredis types * ack PR comments --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Siddharth Ganesan <siddharthganesan@gmail.com>
) * fix(terminal): reconnect to running executions after page refresh * fix(terminal): use ExecutionEvent type instead of any in reconnection stream * fix(execution): type event buffer with ExecutionEvent instead of Record<string, unknown> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(execution): validate fromEventId query param in reconnection endpoint Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix some bugs * fix(variables): fix tag dropdown and cursor alignment in variables block (#3199) * feat(confluence): added list space labels, delete label, delete page prop (#3201) * updated route * ack comments * fix(execution): reset execution state in reconnection cleanup to unblock re-entry Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(execution): restore running entries when reconnection is interrupted by navigation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * done * remove cast in ioredis types * ack PR comments --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Siddharth Ganesan <siddharthganesan@gmail.com>
Summary
variable.tag prefix — fixes dropdown disappearing when typing<variables[1, 2, 3]across variables and input-formatType of Change
Testing
Tested manually
Checklist