fix(change-detection): resolve false positive trigger block change detection#3204
Merged
waleedlatif1 merged 1 commit intostagingfrom Feb 12, 2026
Merged
fix(change-detection): resolve false positive trigger block change detection#3204waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixed false positive "changes detected" for deployed trigger blocks by normalizing trigger configuration values before comparison. The PR addresses the issue where deployed state stores null/empty values for individual trigger fields (like Key changes:
The solution ensures both deployed and current states are normalized consistently before diffing, preventing false positives while still detecting real user changes. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as Deploy Panel
participant Hook as useChangeDetection
participant Compare as hasWorkflowChanged
participant Normalize as normalizeTriggerConfigValues
participant Filter as filterSubBlockIds
UI->>Hook: Request change detection
Hook->>Hook: Build current state with triggerConfig
Note over Hook: Inject triggerConfig for trigger-mode blocks
Hook->>Compare: Compare current vs deployed
Compare->>Normalize: Normalize deployed subBlocks
Note over Normalize: Populate null fields from triggerConfig
Compare->>Normalize: Normalize current subBlocks
Note over Normalize: Populate null fields from triggerConfig
Compare->>Filter: Get comparable subBlock IDs
Note over Filter: Exclude triggerId, triggerConfig, webhookId<br/>Exclude namespaced system IDs (samplePayload_*)
Filter-->>Compare: Filtered IDs
Compare->>Compare: Diff normalized values
Compare-->>Hook: Change detected: true/false
Hook-->>UI: Display changes status
|
waleedlatif1
added a commit
that referenced
this pull request
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
triggerIdto runtime subblock exclusion listsamplePayload_slack_webhook)normalizeTriggerConfigValuesto populate null fields from triggerConfig before comparisonType of Change
Testing
Checklist