Fix a crash issue that happened when#122
Open
Oceankenny wants to merge 1 commit intosocketio:masterfrom
Open
Conversation
1. sio_socket was removed within socket::impl::on_close and destructed. 2. WaitHandler of m_connection_timer(sio_socket::impl::on_close) is triggered although the timer 3. crash when trying to access members of sio_socket::impl since it has been destructed.
Contributor
|
I think you need to handle exist sio::socket lifecycle in socket client callbacks. Simply ignore the clean up when timeout happen will cause the resource leaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sio_client is destructed: