bugfix: has two connect on connection callback#320
Open
mtdxc wants to merge 1 commit intosocketio:masterfrom
Open
bugfix: has two connect on connection callback#320mtdxc wants to merge 1 commit intosocketio:masterfrom
mtdxc wants to merge 1 commit intosocketio:masterfrom
Conversation
io.on('connection', (socket) => {
let addedUser = false;
console.log("new connection");
// when the client emits 'new message', this listens and executes
socket.on('new message', (data) => {
// we tell the client to execute 'new message'
socket.broadcast.emit('new message', {
username: socket.username,
message: data
});
});
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i have woked SioChatDemo with socket.io chatroom example
and found if i connect with default namespace just for one client, node server will got two connection callback.
it sounds like default namespace don't need to call send connection packet, server will handle it.
and then i make a fixed.
here i node.js server code, just add a console.log at connection callback..