update maven plugins versions and fix javadoc-plugin to work with jdk10#518
Open
kristiyanP wants to merge 1 commit intosocketio:masterfrom
Open
update maven plugins versions and fix javadoc-plugin to work with jdk10#518kristiyanP wants to merge 1 commit intosocketio:masterfrom
kristiyanP wants to merge 1 commit intosocketio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROBLEM
If you try to build maven with jdk10 the javadoc generation will fail.
Issue reported here:
https://issues.apache.org/jira/browse/MJAVADOC-517
SOLUTION
Add commons-lang3 dependency to maven-javadoc-plugin
TESTING
On JDK10 works, install, deploy and release
NOTICE
I have also updated the other plugins and removed the parent tag as it has been deprecated see here for more info:
http://central.sonatype.org/pages/apache-maven.html#deprecated-oss-parent