Conversation
m-bert
added
the
New React Native version support
There was a problem hiding this comment.
Pull request overview
This PR adds support for React Native 0.84.0-rc.3 by updating dependencies and iOS build configurations. As noted in the PR description, no specific code changes were required for Gesture Handler compatibility with React Native 0.84.
Changes:
- Updated React Native and related dependencies from 0.83.0 to 0.84.0-rc.3
- Updated iOS Podfile.lock to reflect React Native 0.84's new dependency structure (consolidated third-party deps)
- Enhanced iOS project configuration with iPad support and new architecture flags
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/package.json | Updated React Native and related devDependencies to 0.84.0-rc.3 |
| apps/basic-example/package.json | Updated React Native dependencies to 0.84.0-rc.3 and raised Node.js requirement to >=22.11.0 |
| apps/basic-example/ios/Podfile.lock | Updated all iOS pod dependencies to 0.84.0-rc.3, removed consolidated dependencies (boost, RCT-Folly, SocketRocket), added new dependencies (React-Core-prebuilt, ReactNativeDependencies, React-jsitooling) |
| apps/basic-example/ios/BasicExample/Info.plist | Added separate orientation support for iPad devices |
| apps/basic-example/ios/BasicExample.xcodeproj/project.pbxproj | Added build settings for new architecture support, explicit device family targeting, and Swift module configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "4.2.x": { | ||
| - "react-native": ["0.80", "0.81", "0.82", "0.83"], | ||
| + "react-native": ["0.80", "0.81", "0.82", "0.83", "0.84"], |
There was a problem hiding this comment.
No, they also use this for checks during build, so without adding 0.84 it was impossible to install pods. You can read more about it in this issue.
I think we can wait for stable release and then merge it, so we avoid unnecessary patches for Reanimated.
j-piasecki
left a comment
j-piasecki
left a comment
There was a problem hiding this comment.
LGTM, go ahead with merging after the next Reanimated release
2 participants
Description
Important
No specific changes were necessary to make Gesture Handler compatible with React Native 0.84.
Note
For now this PR contains patch for Reanimated. It will be removed after release.
Status
0.84.0 ✅
Test plan
Tested that
basic-examplebuilds and works correctly.