Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an incorrect pointer type mapping in the iOS Hover gesture handler. The handler was using the raw UIKit enum value UITouchTypePencil instead of the properly mapped gesture handler enum value RNGestureHandlerStylus, causing incorrect pointer type values to be reported in hover gesture events.
Changes:
- Fixed pointer type mapping in
eventExtraDatamethod to useRNGestureHandlerStylusinstead ofUITouchTypePencil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hovergesture events contain wrong pointer type. Normally, we mapUITouchTypePenciltoRNGestureHandlerStylus, butHoverused unmappedUITouchTypePencilinstead.Because those enums map to different values (
UITouchTypePencil = 2&RNGestureHandlerStylus = 1), it caused wrong pointer type to be returned.Fixes #3977
Test plan
Not yet as now I don't have access to iPad 😞