Skip to content

Comments

[iOS] Fix wrong pointerType in Hover gesture#3989

Draft
m-bert wants to merge 1 commit intomainfrom
@mbert/fix-hover-pointerType
Draft

[iOS] Fix wrong pointerType in Hover gesture#3989
m-bert wants to merge 1 commit intomainfrom
@mbert/fix-hover-pointerType

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Feb 20, 2026

Description

Hover gesture events contain wrong pointer type. Normally, we map UITouchTypePencil to RNGestureHandlerStylus, but Hover used unmapped UITouchTypePencil instead.

Because those enums map to different values (UITouchTypePencil = 2 & RNGestureHandlerStylus = 1), it caused wrong pointer type to be returned.

Fixes #3977

Test plan

Not yet as now I don't have access to iPad 😞

Copilot AI review requested due to automatic review settings February 20, 2026 11:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an incorrect pointer type mapping in the iOS Hover gesture handler. The handler was using the raw UIKit enum value UITouchTypePencil instead of the properly mapped gesture handler enum value RNGestureHandlerStylus, causing incorrect pointer type values to be reported in hover gesture events.

Changes:

  • Fixed pointer type mapping in eventExtraData method to use RNGestureHandlerStylus instead of UITouchTypePencil

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Hover gesture reports wrong pointerType

1 participant