Draft
Conversation
milomg
force-pushed
the
legacy
branch
2 times, most recently
from
d3960c3 to
6b56de1
Compare
milomg
force-pushed
the
legacy
branch
2 times, most recently
from
e120f44 to
d3d79af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jspm/generator still uses node
cryptoeven ifintegrityisn't supplied so currently added polyfill. We don't needintegrityhere so, the alternatives arepnpm patch)getIntegrityhttps://github.com/jspm/generator/blob/e922bda037c62b3a8b86351fc08e6269dde3c83e/src/common/integrity.tscryptowith empty mocksNot really sure what we should be doing about existing importmap though. Feel free to suggest anything or take over.