nitro v2: set noExternals to false to avoid bundling native stuff#2056
Open
huseeiin wants to merge 2 commits intosolidjs:mainfrom
Open
nitro v2: set noExternals to false to avoid bundling native stuff#2056huseeiin wants to merge 2 commits intosolidjs:mainfrom
huseeiin wants to merge 2 commits intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7f71b46 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
katywings
approved these changes
Jan 27, 2026
brenelz
reviewed
Feb 4, 2026
| baseURL: "/", | ||
| }, | ||
| ], | ||
| noExternals: false, |
Contributor
There was a problem hiding this comment.
seems odd that it would be this easy but maybe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes nitro v2 plugin on par with solid start v1 (vinxi)
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information