-
Notifications
You must be signed in to change notification settings - Fork 408
disable organizeImports and set oxc formatter and upgrade oxfmt #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
| { | ||
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": "explicit" | ||
| // "source.organizeImports": "explicit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if json likes comments like this does it? The syntax highlighting seems off which is why i wonder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if json likes comments like this does it? The syntax highlighting seems off which is why i wonder
vscode uses special variant of json called jsonc so it works
|
also set "trailingComma" to "es5" to fix prettier's formatting if someone ran prettier on accident :) |
no, bad |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information