Skip to content

Conversation

@huseeiin
Copy link
Contributor

@huseeiin huseeiin commented Feb 3, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit e5fdb8c
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69833eabbafad30008660d7b
😎 Deploy Preview https://deploy-preview-2062--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: e5fdb8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2062
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2062

commit: e5fdb8c

{
"editor.codeActionsOnSave": {
"source.organizeImports": "explicit"
// "source.organizeImports": "explicit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if json likes comments like this does it? The syntax highlighting seems off which is why i wonder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if json likes comments like this does it? The syntax highlighting seems off which is why i wonder

vscode uses special variant of json called jsonc so it works

@huseeiin huseeiin changed the title disable organizeImports and set oxc formatter disable organizeImports and set oxc formatter and upgrade oxc Feb 4, 2026
@huseeiin huseeiin changed the title disable organizeImports and set oxc formatter and upgrade oxc disable organizeImports and set oxc formatter and upgrade oxfmt Feb 4, 2026
@huseeiin
Copy link
Contributor Author

huseeiin commented Feb 4, 2026

also set "trailingComma" to "es5" to fix prettier's formatting if someone ran prettier on accident :)

@huseeiin
Copy link
Contributor Author

huseeiin commented Feb 4, 2026

also set "trailingComma" to "es5" to fix prettier's formatting if someone ran prettier on accident :)

no, bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants