Skip to content

remove VolumeAttachLimit from STACKIT CSI#18

Merged
ske-prow[bot] merged 1 commit intomainfrom
remove-attach-volume
Feb 26, 2026
Merged

remove VolumeAttachLimit from STACKIT CSI#18
ske-prow[bot] merged 1 commit intomainfrom
remove-attach-volume

Conversation

@breuerfelix
Copy link
Member

How to categorize this PR?

/kind technical-debt

What this PR does / why we need it:
The helmchart value is never used so we can remove it.

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2026
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@ske-prow
Copy link

ske-prow bot commented Feb 26, 2026

LGTM label has been added.

DetailsGit tree hash: e65cf4b2a8db33f7129dbec1b98a562bbd91ef46

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@nschad
Copy link

nschad commented Feb 26, 2026

thanks @breuerfelix, need to fix the test though

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@ske-prow ske-prow bot requested a review from nschad February 26, 2026 08:32
@nschad
Copy link

nschad commented Feb 26, 2026

/override pull-gardener-extension-provider-stackit-infra-integration-tests

@ske-prow
Copy link

ske-prow bot commented Feb 26, 2026

@nschad: Overrode contexts on behalf of nschad: pull-gardener-extension-provider-stackit-infra-integration-tests

Details

In response to this:

/override pull-gardener-extension-provider-stackit-infra-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@ske-prow
Copy link

ske-prow bot commented Feb 26, 2026

LGTM label has been added.

DetailsGit tree hash: a2d1e0b406cfb50b8640ae1bb30d35082c8d111b

@ske-prow
Copy link

ske-prow bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot merged commit 0f22785 into main Feb 26, 2026
4 checks passed
@ske-prow ske-prow bot deleted the remove-attach-volume branch February 26, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants