add validator to block zone creation with trailing dot#1225
Merged
rubenhoenle merged 2 commits intostackitcloud:mainfrom Feb 25, 2026
Merged
add validator to block zone creation with trailing dot#1225rubenhoenle merged 2 commits intostackitcloud:mainfrom
rubenhoenle merged 2 commits intostackitcloud:mainfrom
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Contributor
Author
|
comment to remove stale label |
rubenhoenle
approved these changes
Feb 24, 2026
cgoetz-inovex
approved these changes
Feb 25, 2026
Fyusel
approved these changes
Feb 25, 2026
rubenhoenle
force-pushed
the
feature/validate-zone-dns-name
branch
from
57ea30d to
3a7d379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The STACKIT DNS API will always return a zone without a trailing dot, even it specified in the create call. SInce this will break the terraform state I added a validator to block creation of those zones. (All zones can still be created, just without the trailing dot)
relates to #1083
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)