-
Notifications
You must be signed in to change notification settings - Fork 2
Document tool definitions annotation support #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR documents the new toolhive.stacklok.dev/tool-definitions annotation that allows registry users to specify MCP tool metadata directly in Kubernetes resource annotations. This feature enables tool discovery information to be embedded in the registry without requiring separate API calls.
Changes:
- Added documentation for the
tool-definitionsannotation in the registry configuration guide - Included a YAML example showing how to specify tool definitions in annotations
- Explained validation behavior, API response format, and supported metadata fields
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
|
@copilot re-review the changes after addressed feedback |
|
@copilot re-review the changes in this PR, do not create a new PR nor attempt to do any code changes. Just re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
|
@lujunsan I'm not up to speed on this feature in the registry so it would be better if someone else from the team reviews this one. |
Summary
toolhive.stacklok.dev/tool-definitionsannotationRelated
Implements documentation for stacklok/toolhive-registry-server#414 (registry-server implementation of RFC-0015)
Changes
docs/toolhive/guides-registry/configuration.mdx:tool-definitionsannotation to the annotations table