Add MultimodalJambaEHR with UnifiedMultimodalEmbedding and TemporalFeatureProcessor#874
Open
joshuasteier wants to merge 1 commit intosunlabuiuc:masterfrom
Open
Conversation
4095ec6 to
cd82d07
Compare
0b6218b to
cd82d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor
Description
Adds the multimodal Jamba backbone, unified multimodal embedding layer, and temporal feature processor abstract base class for the multimodal mortality prediction pipeline.
Files
pyhealth/models/multimodal_jamba.pyMultimodalJambaEHR,UnifiedMultimodalEmbedding,JambaBackbonewith 3-tier Mamba backend (mamba-ssm CUDA → PyHealth MambaBlock → pure PyTorch parallel scan)pyhealth/processors/temporal_feature_processor.pyTemporalFeatureProcessorabstract base class — Rian's text processor and William's timeseries processor should inherit from thistests/core/test_multimodal_jamba.pyArchitecture
Missing Modality Handling (per Feb 16 meeting notes)
Mamba Backend Priority
mamba-ssmCUDA kernels (fastest,pip install mamba-ssm)MambaBlockfromehr_mamba.pyOn the campus cluster with
mamba-ssminstalled, it auto-selects CUDA. No code changes needed.Testing
All 36 tests pass.
Usage
Note on BaseModel
Currently inherits
nn.Moduleinstead of PyHealthBaseModel. This is intentional —BaseModelintegration requires the full processor → dataset → task pipeline (William's multimodal task + processors). Will be updated once those pieces land.