fix: use correct docker.sock binding with vector (fixes #3127, #3512, #3593)

[unlair]

This fixes Docker Desktop on Linux failing to start the vector container. The container tries to bind to the Docker Desktop socket directly, which is unsupported. This fix resolves #3127, #3512, and #3593.

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

When using Docker Desktop on Linux, Vector fails to start when doing supabase start.

What is the new behavior?

When using Docker Desktop on Linux, Vector successfully starts when doing supabase start.

Additional context

Using Docker or Docker Desktop on Linux, the specified host binding path to the Docker socket should be /var/run/docker.sock, as that path has special handling under the hood (see docker/for-mac#6545 (comment)). Note that it does not directly use the socket sitting at /var/run/docker.sock on the host machine. My understanding is that what it ends up doing under the hood is essentially using what you get with /var/run/docker.sock.raw from outside Docker, as mentioned here: https://docs.docker.com/extensions/extensions-sdk/guides/use-docker-socket-from-backend/

Summary by CodeRabbit

• Bug Fixes
  • Improved Docker socket handling: now automatically recognizes both standard and Docker Desktop socket locations, binds the root socket read-only to the daemon host, and removes prior warning messages for those cases for more consistent container socket configuration.

[coveralls]

Pull Request Test Coverage Report for Build 21680537186

Details

• 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
• 7 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.03%) to 55.345%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/start/start.go	0	4	0.0%

Files with Coverage Reduction	New Missed Lines	%
internal/storage/rm/rm.go	2	80.61%
internal/gen/keys/keys.go	5	12.9%

Totals
Change from base Build 21669533478:	-0.03%
Covered Lines:	7114
Relevant Lines:	12854

---

💛 - Coveralls

[coderabbitai]

📝 Walkthrough

Walkthrough

Expanded unix Docker socket handling to treat both /.docker/run/docker.sock and /.docker/desktop/docker.sock as root-socket cases. For these paths the code now appends a read-only bind to the Docker daemon host and skips the previous warning path, preserving prior behavior for other socket cases.

Changes

Cohort / File(s)	Summary
Docker Socket Binding internal/start/start.go	Recognize Docker Desktop socket path (/.docker/desktop/docker.sock) alongside /.docker/run/docker.sock as root-socket cases; remove warning branch and add a read-only bind mount for these root socket paths. Other socket handling remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR addresses the core requirement from #3593 by modifying docker.sock binding logic to use /var/run/docker.sock instead of the direct Docker Desktop socket path, resolving mount-denied failures.
Out of Scope Changes check	✅ Passed	The changes are narrowly scoped to internal/start/start.go, modifying only the Docker socket binding logic to handle both /.docker/run/docker.sock and /.docker/desktop/docker.sock cases as required by #3593.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into develop
Title check	✅ Passed	The title 'fix: use correct docker.sock binding with vector (fixes #3127, #3512, #3593)' directly and specifically describes the main change: correcting Docker socket binding for Vector containers on Docker Desktop.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}