fix(config): replace external-url into studio api

[9bany]

What kind of change does this PR introduce?

Fix TODO noted in code based

What is the current behavior?

This PR remove external-url in config, remove depended of studio.api on the external-url

What is the new behavior?

The studio.api variable is set directly in the Load configuration.

Additional context

None

[9bany]

Could you please check this PR @sweatybridge ?

[sweatybridge]

The TODO is actually meant to keep Api.ExternalUrl and delete Studio.ApiUrl

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5b8ed and 7852108.

📒 Files selected for processing (5)

• internal/start/start.go
• pkg/config/api.go
• pkg/config/config.go
• pkg/config/templates/config.toml
• pkg/config/testdata/config.toml

💤 Files with no reviewable changes (2)

• pkg/config/testdata/config.toml
• pkg/config/config.go

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • External URL configuration has been moved from studio-specific to a global setting, simplifying configuration management and allowing centralized control.

Walkthrough

The changes refactor the API external URL configuration from a studio-specific field to a global API configuration field. The Studio.ApiUrl field is removed from the config struct, and its validation logic is eliminated. The Api.ExternalUrl field is newly exposed in TOML and JSON serialization with the tag toml:"external_url". Configuration templates are updated to include a global external_url option in place of the studio-specific api_url. The startup code is updated to reference utils.Config.Api.ExternalUrl instead of utils.Config.Studio.ApiUrl for the Studio container's public URL.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[9bany]

Sorry for the late response,
Please check again, thanks a lot @sweatybridge