Added final newline character in two Ruby templates#12473
Open
prioux wants to merge 2 commits intoswagger-api:masterfrom
Open
Added final newline character in two Ruby templates#12473prioux wants to merge 2 commits intoswagger-api:masterfrom
prioux wants to merge 2 commits intoswagger-api:masterfrom
Conversation
The two mustache templates for Ruby models were not properly terminated with a newline character, causing the generated Ruby code to be syntactically incorrect. Code generate before this fix: code code endend Code generated after this fix: code code end end
Author
|
Hello? Any code reviewer out there? This PR is literally only inserting two newline characters. Two bytes. And it fixes a genuine bug in the code generator. Please have a look? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix. The two mustache templates for Ruby models were not properly terminated with a newline character, causing the generated Ruby code to be syntactically incorrect.
Code generated before this fix:
Code generated after this fix:
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)