Conversation
a14e315 to
fa55c65
Compare
|
Drafted to give precedence to other PRs |
c3a906d to
a794374
Compare
b5e1f67 to
0668e8a
Compare
| "fee__fast__longTitle" = "Fast (more expensive)"; | ||
| "fee__fast__description" = "±10 minutes"; | ||
| "fee__fast__shortDescription" = "±10m"; | ||
| "fee__fast__range" = "±10-20 minutes"; |
There was a problem hiding this comment.
Missing translations: fee__*__range, wallet__activity_transferring, and wallet__activity_in_transfer are absent from all non-English locales
These new localization keys were added to en.lproj in this PR but are missing from all 14 other locale files (ca, cs, de, el, es, es-419, fr, it, nl, pl, pt-BR, ru, and others):
fee__fast__range,fee__normal__range,fee__slow__range,fee__minimum__range,fee__custom__range— used at runtime inFeeItem.swift(viaspeed.range),SendFeeRate.swift(viacustomFeeRangeOverride), andSendConfirmationView.swiftwallet__activity_transferring— used inActivityRowOnchain.swiftfor the status label of unconfirmed transferswallet__activity_in_transfer— used inActivityItemView.swiftfor the detail view status
The non-English locale files did receive fee__*__longRange and fee__*__longTitle translations, but not the shorter fee__*__range variants. For users on any non-English locale, t("fee__fast__range") etc. will return the raw key string instead of a translated duration.
See:
bitkit-ios/Bitkit/Resources/Localization/en.lproj/Localizable.strings
Lines 90 to 95 in 45f8dd0
Code reviewFound 3 issues: 1. Compile error — type mismatch in
2. This key is used in 3. Several new keys missing from non-English locale files (link) The following keys were added to |
Is this how it works?! 🤦🏻 In Android it simply shows the non-translated text using the default locale, ie. English copy. |
No it's making shit up, it falls back to English. |
Description
Mostly a refactor/cleanup but also adds a way to override fee estimates in debug mode (useful for UI work) and aims to show estimated confirmation time when a custom fee is set, instead of "Depends on fee".
.modern,.bitcoindenomination for custom fee UIsatsPerVbyte, estimates cache warmed in ActivityList/ActivityLatest .task)Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-05.at.17.29.39.mov