Skip to content

fix: add missing parentheses to core.isDebug()#268

Merged
mpminardi merged 2 commits intotailscale:mainfrom
git-mracek:patch-1
Feb 25, 2026
Merged

fix: add missing parentheses to core.isDebug()#268
mpminardi merged 2 commits intotailscale:mainfrom
git-mracek:patch-1

Conversation

@git-mracek
Copy link
Contributor

This PR fixes a small but critical bug in src/main.ts that swallows the stderr output of failed commands when action debug logging is disabled.

The Issue:
Currently, around line 938 in the execSilent function, the code checks if debug logging is off:
if (!core.isDebug) {

Since core.isDebug is a function in the @actions/core package, !core.isDebug always evaluates to false. As a result, the fallback process.stderr.write(out.stderr); is never executed.

When a command (like tailscale up) fails, users only see a generic sudo failed with exit code X instead of the actual error message from the Tailscale CLI. This makes troubleshooting extremely difficult.

The Fix:
Added the missing parentheses (!core.isDebug()) so the function is actually called and evaluates the boolean correctly. Now, users will properly see the CLI errors in their action logs.

Copy link
Member

@mpminardi mpminardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@git-mracek thanks for the fix, and apologies for the miss here!

@mpminardi
Copy link
Member

mpminardi commented Feb 25, 2026

FYI we'll need to do a make build and commit / push the results from that to resolve the linter error.

@git-mracek
Copy link
Contributor Author

@mpminardi Done! I've run make build and pushed the updated dist/ files. The PR should be ready now.

@mpminardi mpminardi merged commit 564fe38 into tailscale:main Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants