android: fix silent login failure and double browser#746
Merged
Conversation
login() has a race where, when WantRunning transitions from false to true, cc.Login is called on the current control client; this races with start() tearing down the old control client and creating a new one. In a slow network, start() resets the old client before the auth URL is received, and no new browse URL is created for the new client. -We fix this by not setting WantRunning=true until starting Also clear the Notifier.browseToURL before relaunching MainActivity after auth to resolve issue where there is a second browser that reopens with the already consuemd URL Updates tailscale/tailscale#18304 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
force-pushed
the
kari/loginlog
branch
from
7c11d57 to
8305786
Compare
barnstar
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login() has a race where, when WantRunning transitions from false to true, cc.Login is called on the current control client; this races with start() tearing down the old control client and creating a new one. In a slow network, start() resets the old client before the auth URL is received, and no new browse URL is created for the new client. -We fix this by not setting WantRunning=true until starting
Also clear the Notifier.browseToURL before relaunching MainActivity after auth to resolve issue where there is a second browser that reopens with the already consuemd URL