Open
Conversation
Pull Request Test Coverage Report for Build 22361463977Details
💛 - Coveralls |
oleg-jukovec
requested changes
Feb 24, 2026
Comment on lines
111
to
125
| ## Building from the source | ||
|
|
||
| To build sharded-queue from source luarocks tool is required. | ||
| Install .rockspec file and package of needed version. | ||
|
|
||
| For example: | ||
| ```shell | ||
| curl -L -O http://rocks.tarantool.org/sharded-queue-1.0.0-1.rockspec | ||
| dpkg-deb -x sharded-queue_1.0.0-1_all.deb | ||
| ``` | ||
|
|
||
| After run application build: | ||
| ```shell | ||
| luarocks make sharded-queue-1.0.0-1.rockspec | ||
| ``` |
Contributor
There was a problem hiding this comment.
We need although an instruction how to download a pre-builded rock & raw rockspec from a rock-server for a specified version.
Contributor
Author
There was a problem hiding this comment.
Added an instruction about pre-builded .rock file.
oleg-jukovec
requested changes
Feb 24, 2026
README.md
Outdated
|
|
||
| After run application build: | ||
| ```shell | ||
| luarocks make sharded-queue-1.0.0-1.rockspec |
Contributor
There was a problem hiding this comment.
Suggested change
| luarocks make sharded-queue-1.0.0-1.rockspec | |
| tt rocks make sharded-queue-1.0.0-1.rockspec |
Contributor
Author
There was a problem hiding this comment.
Thanks, replaced.
Col-Waltz
force-pushed
the
i.ostanevich/tntp-6410-rock-file-readme
branch
2 times, most recently
from
5c611c3 to
fb5fe80
Compare
oleg-jukovec
requested changes
Feb 24, 2026
Comment on lines
126
to
132
|
|
||
| As alternative, application can be installed by pre-builded.rock file. | ||
| Download file and move it to the preferred place, then run tt rocks: | ||
| ```shell | ||
| curl -L -O http://rocks.tarantool.org/sharded-queue-1.0.0-1.all.rock | ||
| tt rocks install sharded-queue-1.0.0-1.all.rock | ||
| ``` |
Contributor
There was a problem hiding this comment.
Please, add a separate title for downloading pre-builded rock/rockspec.
Suggested change
| As alternative, application can be installed by pre-builded.rock file. | |
| Download file and move it to the preferred place, then run tt rocks: | |
| ```shell | |
| curl -L -O http://rocks.tarantool.org/sharded-queue-1.0.0-1.all.rock | |
| tt rocks install sharded-queue-1.0.0-1.all.rock | |
| ``` | |
| ## Downloading pre-builded rock/rockspec | |
| As alternative, application can be installed by pre-builded.rock file. | |
| Download file and move it to the preferred place, then run tt rocks: | |
| ```shell | |
| curl -L -O http://rocks.tarantool.org/sharded-queue-1.0.0-1.all.rock | |
| tt rocks install sharded-queue-1.0.0-1.all.rock |
Contributor
Author
There was a problem hiding this comment.
Thanks, added title.
README.md
Outdated
| As alternative, application can be installed by pre-builded.rock file. | ||
| Download file and move it to the preferred place, then run tt rocks: | ||
| ```shell | ||
| curl -L -O http://rocks.tarantool.org/sharded-queue-1.0.0-1.all.rock |
Contributor
There was a problem hiding this comment.
Why do you don't use the tt rocks download for the purpose? It would be better rather the curl.
Contributor
Author
There was a problem hiding this comment.
Okay, I replaced all curl calls with equivalent tt calls for download purpose.
Col-Waltz
force-pushed
the
i.ostanevich/tntp-6410-rock-file-readme
branch
from
fb5fe80 to
597c8d4
Compare
Add instructions on how to download .rockspec file and then install the module.
Col-Waltz
force-pushed
the
i.ostanevich/tntp-6410-rock-file-readme
branch
from
597c8d4 to
b82d710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instructions on how to download .rockspec file and then install the module.