Fix PHP 8.5 deprecation on curl_close()#838
Merged
nicolaasuni merged 1 commit intotecnickcom:mainfrom Mar 1, 2026
Merged
Conversation
curl_close() is noop since 8.0.0 and deprecated since 8.5.0
|
|
|
Same should be done with imagedestroy. See attached patch. There is code that checks for 'safe_mode', which was removed in PHP 5.4 (not fixed in patch). |
Contributor
|
Fixes #850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_close()is noop since 8.0.0 and emitsE_DEPRECATEDsince 8.5.0.This changes the code to call
curl_close()only on PHP < 8.0.0.