Preserve Raw Error Type in Nexus Handler Errors#1265
Closed
VegetarianOrc wants to merge 1 commit intomainfrom
Closed
Preserve Raw Error Type in Nexus Handler Errors#1265VegetarianOrc wants to merge 1 commit intomainfrom
VegetarianOrc wants to merge 1 commit intomainfrom
Conversation
…n error type string. Refactor converter to use the string constructor rather than determining the nexusrpc.HandlerErrorType. Update references to nexusrpc.HandlerError to use the renamed error_type field.
Member
|
@VegetarianOrc - can you also delete the branches associated w/ these PRs that are being closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to nexus-rpc that allows creating nexusrpc.HandlerError from an error type string. Refactor converter to use the string constructor rather than determining the nexusrpc.HandlerErrorType. Update references to nexusrpc.HandlerError to use the renamed error_type field.
What was changed
Why?
The nexus-rpc library now supports creating HandlerError instances directly from error type strings rather than requiring enum values. This change:
Checklist
How was this tested