Upgrade on CAN (needs test) #1311
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
reviewed
Jan 29, 2026
| For example, choose to AutoUpgrade on continue-as-new instead of inheriting the pinned version | ||
| of the previous run. | ||
| """ | ||
| UNSPECIFIED = int(temporalio.api.enums.v1.ContinueAsNewVersioningBehavior.CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_UNSPECIFIED) |
Contributor
There was a problem hiding this comment.
I think unspecified needs a comment of what it does.
tconley1428
reviewed
Jan 29, 2026
|
|
||
| class SuggestContinueAsNewReason(IntEnum): | ||
| """SuggestContinueAsNewReason specifies a reason why continue as new is true.""" | ||
| SUGGEST_CONTINUE_AS_NEW_REASON_UNSPECIFIED = int(temporalio.api.enums.v1.SuggestContinueAsNewReason.SUGGEST_CONTINUE_AS_NEW_REASON_UNSPECIFIED) |
Contributor
There was a problem hiding this comment.
Maybe less interesting to, but also what unspecified means here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Propagate CAN versioning and CAN suggested reasons to Python.
Why?
Users can specify auto-upgrade behavior on CAN.
Part of Expose upgrade on continue as new in SDKs features#738
How was this tested:
To be added
Any docs updates needed?
Maybe?