Skip to content

Stop skipping some Nexus tests on time skipping test server #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quinn-With-Two-Ns wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Stop skipping some Nexus tests on time skipping test server #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
136444c
Stop skipping some Nexus tests
Quinn-With-Two-Ns Feb 23, 2026
2ee4423
Enable more tests
Quinn-With-Two-Ns Feb 23, 2026
3233cfa
Fix lint error
Quinn-With-Two-Ns Feb 23, 2026
e2e48be
Keep skipping headers test
Quinn-With-Two-Ns Feb 23, 2026
885180d
Skip test_cancel_operation_headers
Quinn-With-Two-Ns Feb 23, 2026
9a5fa13
Merge branch 'main' into nexus-tests
tconley1428 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/nexus/test_use_existing_conflict_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import uuid
from dataclasses import dataclass

import pytest
from nexusrpc.handler import service_handler

from temporalio import nexus, workflow
Expand Down Expand Up @@ -91,9 +90,6 @@ async def nexus_operations_have_started(self) -> None:
async def test_multiple_operation_invocations_can_connect_to_same_handler_workflow(
client: Client, env: WorkflowEnvironment
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = str(uuid.uuid4())
workflow_id = str(uuid.uuid4())

Expand Down
25 changes: 0 additions & 25 deletions tests/nexus/test_workflow_caller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,8 +593,6 @@ async def run(self, input: WorkflowRunHeaderTestCallerWfInput) -> HeaderTestOutp


async def test_sync_operation_happy_path(client: Client, env: WorkflowEnvironment):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")
task_queue = str(uuid.uuid4())
async with Worker(
client,
Expand Down Expand Up @@ -631,8 +629,6 @@ async def test_sync_operation_happy_path(client: Client, env: WorkflowEnvironmen
async def test_workflow_run_operation_happy_path(
client: Client, env: WorkflowEnvironment
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")
task_queue = str(uuid.uuid4())
async with Worker(
client,
Expand Down Expand Up @@ -833,9 +829,6 @@ async def test_workflow_run_operation_headers(
env: WorkflowEnvironment,
):
"""Test that headers are propagated to @workflow_run_operation handlers."""
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = str(uuid.uuid4())
test_headers = {"x-custom-workflow-run": "workflow-run-value"}

Expand Down Expand Up @@ -1317,9 +1310,6 @@ async def run(
async def test_service_interface_and_implementation_names(
client: Client, env: WorkflowEnvironment
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

# Note that:
# - The caller can specify the service & operation via a reference to either the
# interface or implementation class.
Expand Down Expand Up @@ -1448,9 +1438,6 @@ async def test_workflow_run_operation_can_execute_workflow_before_starting_backi
client: Client,
env: WorkflowEnvironment,
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = str(uuid.uuid4())
async with Worker(
client,
Expand Down Expand Up @@ -1504,9 +1491,6 @@ async def test_nexus_operation_summary(
client: Client,
env: WorkflowEnvironment,
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = f"task-queue-{uuid.uuid4()}"
async with Worker(
client,
Expand Down Expand Up @@ -1799,9 +1783,6 @@ async def run(self, op: str, input: OverloadTestValue) -> OverloadTestValue:
async def test_workflow_run_operation_overloads(
client: Client, env: WorkflowEnvironment, op: str
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = str(uuid.uuid4())
async with Worker(
client,
Expand Down Expand Up @@ -1870,9 +1851,6 @@ async def run(self, task_queue: str) -> None:


async def test_workflow_caller_custom_metrics(client: Client, env: WorkflowEnvironment):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

task_queue = str(uuid.uuid4())
endpoint_name = make_nexus_endpoint_name(task_queue)
await env.create_nexus_endpoint(endpoint_name, task_queue)
Expand Down Expand Up @@ -1949,9 +1927,6 @@ async def test_workflow_caller_custom_metrics(client: Client, env: WorkflowEnvir
async def test_workflow_caller_buffered_metrics(
client: Client, env: WorkflowEnvironment
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

# Create runtime with metric buffer
buffer = MetricBuffer(10000)
runtime = Runtime(
Expand Down
3 changes: 0 additions & 3 deletions tests/nexus/test_workflow_caller_cancellation_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,6 @@ async def test_cancellation_type(
env: WorkflowEnvironment,
cancellation_type_name: str,
):
if env.supports_time_skipping:
pytest.skip("Nexus tests don't work with time-skipping server")

cancellation_type = workflow.NexusOperationCancellationType[cancellation_type_name]
global test_context
test_context = TestContext(
Expand Down
Loading