Open
Conversation
donald-pinckney
force-pushed
the
add-ts
branch
from
4a01cfe to
009d465
Compare
donald-pinckney
force-pushed
the
add-ts
branch
from
ecc845d to
3f948ef
Compare
donald-pinckney
commented
Feb 27, 2026
|
|
||
| The TypeScript SDK provides `TestWorkflowEnvironment` for testing workflows with time-skipping and activity mocking support. Use `createTimeSkipping()` for automatic time advancement when testing workflows with timers, or `createLocal()` for a full local server without time-skipping. | ||
|
|
||
| **Note:** Prefer to use `createLocal()` for full-featured support. Only use `createTimeSkipping()` if you genuinely need time skipping for testing your workflow. |
Collaborator
Author
There was a problem hiding this comment.
Is this correct? Like it is in Python, is it also preferable to use createLocal rather than createTimeSkipping in TypeScript? (unless you need time skipping).
donald-pinckney
commented
Feb 27, 2026
| import { AsyncCompletionClient } from '@temporalio/client'; | ||
|
|
||
| async function doSomeWork(taskToken: Uint8Array): Promise<void> { | ||
| const client = new AsyncCompletionClient(); |
Collaborator
Author
There was a problem hiding this comment.
Is new AsyncCompletionClient() or new Client().activity preferred here? Official sources are contradictory actually.
- API Docs say "Typically AsyncCompletionClient should not be instantiated directly"
- The docs / samples only show directly instantiating
AsyncCompletionClient
mjameswh
reviewed
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript support for
temporal-developerskill!This PR adds TypeScript support into the skill. Its structure is parallel and similar to Python's.
Several automated agentic review passes were done on this content to check for content alignment with
pythonandcore, and to compare against docs for factual accuracy.