Open
Conversation
Contributor
|
Thanks. Since the project is tied to a tutorial -- https://testdriven.io/blog/fastapi-sqlmodel/ -- the code and tutorial need to be updated at the same time. I should have some time later this month to look at this. |
Merged
Contributor
|
Apologies for the delay, @jonra1993. It's really difficult to accept PRs from folks who are not also updating the tutorial at the same time. @amirtds and I updated both. We captured most of your changes. If you still want to contribute, please address the merge conflicts. Thank you! |
vinay7agarwal
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this fast API setup. In this Pull request, I have added some suggestions on issues