make apache ports configurable#361
Open
mms-gianni wants to merge 6 commits intothecodingmachine:v4from
Open
Conversation
Signed-off-by: Gianni Carafa <gianni.carafa@srf.ch>
This reverts commit d7f5f15.
Signed-off-by: Gianni Carafa <gianni.carafa@srf.ch>
mistraloz
requested changes
Apr 4, 2023
Author
|
I can squash the commits if prefered. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please update it if any action still required. |
|
This issue has been automatically closed because it has not had recent activity. Please, reopen if you need. |
mistraloz
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements :
Explain the motivation for making this change. What existing problem does the pull request solve?
Adds the possibility to run the apache on a different port than 80 and 443.
See issue #360
Test plan (required)
The ports will be configured on startup by entrypoint.
Need some help here to test it.
Checklist