Add safe wrapper for unserialize #720
Merged
+89
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to this repository, feedback is appreciated.
PHP default behavior for strings that cannot be unserialized is to return a false and emit an E_WARNING (or E_NOTICE depending on PHP version).
This wrapper tries to guarantee that something like that will in fact throw an
ErrorExceptionby setting a custom error handler, executing the function, and then restoring it to its previous state.I believe this is necessary because there is a scenario where an unserialize call, although successful, returns a false because the previous serialized value was indeed a false boolean, and not because an error happened during unserialization.