Automatically determine prefix and suffix from tags#172
Open
thomas-neitmann wants to merge 3 commits intothomasp85:mainfrom
Open
Automatically determine prefix and suffix from tags#172thomas-neitmann wants to merge 3 commits intothomasp85:mainfrom
thomas-neitmann wants to merge 3 commits intothomasp85:mainfrom
Conversation
Owner
|
On second thought, I think the best approach is something incorporating glue. Your current checks for which formats to use will fail if prefix or suffix contains any of the recognised tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented an automatic detection of the
tag_prefixandtag_suffixfrom thetag_levelsas described in #169. It works like this:tag_levelscontains one of the supported tags usinggrepl()tag_levelsis longer than 1 character then find the index of the supported tag insidetag_levelstag_prefixtag_suffixSome examples:
tag_levels = "A",tag_prefixandtag_suffixare left blank.tag_levels = "[A",tag_prefixis set to"]"andtag_suffixis left blank.tag_levels = "A}",tag_prefixis left blank andtag_suffixis set to"}".tag_levels = "(A)",tag_prefixis is set to"("andtag_suffixis set to")".Importantly, in the current implentation the automatic detection of the prefix is not "activated" when
tag_prefixis set. The same is true for the suffix istag_suffixis set.