Feature: allow setting up custom environment when creating windows and/or panes#453
Merged
tony merged 4 commits intotmux-python:masterfrom Nov 6, 2022
Conversation
Member
|
@zappolowski FYI on timeline, I may not be able to give this my undivided attention until the evening (weekends latest) |
zappolowski
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
from
e67fb47 to
3576909
Compare
tony
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
2 times, most recently
from
2295b53 to
9ddfbb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 87.46% 87.68% +0.22%
==========================================
Files 20 20
Lines 1803 1852 +49
Branches 280 298 +18
==========================================
+ Hits 1577 1624 +47
Misses 154 154
- Partials 72 74 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
reviewed
Nov 5, 2022
tony
reviewed
Nov 5, 2022
tony
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
2 times, most recently
from
9ddfbb8 to
6c0457f
Compare
tony
reviewed
Nov 5, 2022
tony
reviewed
Nov 5, 2022
tony
previously approved these changes
Nov 5, 2022
Member
tony
left a comment
tony
left a comment
There was a problem hiding this comment.
LGTM
Fine to squash the commits as you see fit
zappolowski
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
from
8e24396 to
9016222
Compare
Member
|
@zappolowski Game plan I will merge #455 and make a patch release for we can then merge this (i will rebase) and do final check, if it looks good, will release 0.16.0 |
tony
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
from
9016222 to
214c692
Compare
Member
|
v0.15.10: GitHub Release, docs site, change file, PyPI |
tony
reviewed
Nov 5, 2022
This allows to set up a custom environment when creating a new window.
This allows to set up a custom environment when creating a new pane.
zappolowski
force-pushed
the
feature/set-environment-for-windows-and-panes
branch
from
0f293af to
4244049
Compare
Member
|
@zappolowski I didn't get a notification of the push! Merging and publishing now |
tony
added a commit
to tmux-python/tmuxp
that referenced
this pull request
Nov 6, 2022
Passthrough of environmental variables via -e in tmux 3.0 and above. See also: tmux-python/libtmux#453
Member
|
The floor is yours to address tmux-python/tmuxp#832 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for implementing tmux-python/tmuxp#832.