-
Notifications
You must be signed in to change notification settings - Fork 9
Add Jinja2 template validation test and pre-commit hook #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| """Tests for cloud-init template parsing and rendering.""" | ||
|
|
||
| from jinja2 import Template, TemplateSyntaxError | ||
|
|
||
| from dropkit.config import Config | ||
|
|
||
|
|
||
| def _load_default_template() -> str: | ||
| """Load the default cloud-init template content.""" | ||
| path = Config.get_default_template_path() | ||
| return path.read_text() | ||
|
|
||
|
|
||
| def test_default_template_parses(): | ||
| """Verify the default template is valid Jinja2 syntax.""" | ||
| content = _load_default_template() | ||
| try: | ||
| Template(content) | ||
| except TemplateSyntaxError as exc: | ||
| raise AssertionError(f"Template has Jinja2 syntax error: {exc}") from exc | ||
|
|
||
|
|
||
| def test_default_template_renders(): | ||
| """Verify the template renders with sample variables.""" | ||
| content = _load_default_template() | ||
| template = Template(content) | ||
| rendered = template.render( | ||
| username="testuser", | ||
| full_name="Test User", | ||
| email="test@example.com", | ||
| ssh_keys=["ssh-ed25519 AAAAC3... test@host"], | ||
| tailscale_enabled=True, | ||
| ) | ||
| assert "testuser" in rendered | ||
| assert "ssh-ed25519 AAAAC3... test@host" in rendered | ||
| assert "git config --global user.name 'Test User'" in rendered | ||
| assert "git config --global user.email 'test@example.com'" in rendered | ||
| assert "tailscale" in rendered | ||
|
|
||
|
|
||
| def test_default_template_renders_without_tailscale(): | ||
| """Verify the Tailscale section is absent when disabled.""" | ||
| content = _load_default_template() | ||
| template = Template(content) | ||
| rendered = template.render( | ||
| username="testuser", | ||
| full_name="Test User", | ||
| email="test@example.com", | ||
| ssh_keys=["ssh-ed25519 AAAAC3... test@host"], | ||
| tailscale_enabled=False, | ||
| ) | ||
| assert "testuser" in rendered | ||
| assert "tailscale.com/install.sh" not in rendered |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that's more resilient?