docs: fix self-hosting section in deploy docs#2836
Conversation
Remove deprecated flags (--self-hosted, --skip-deploy, --load-image, --registry, --namespace) and add current options (--local-build, --load, --native-build-server, --detach). Update examples to show correct usage for self-hosted deployments. Fixes #2835
- Remove hidden CLI flags from docs (--load, --push, --network) - Clarify that v4 self-hosted builds are local by default - Remove deprecated --self-hosted flag from examples - Reference GitHub Actions guide for CI setup - Simplify GitHub Actions self-hosting example Fixes #2835
- Move --local-build param to correct location with other options - Fix self-hosting link to /self-hosting/overview - Show simple deploy command first (after CLI login) - Move CI env vars mention to secondary position
|
WalkthroughThis PR updates self-hosting documentation across two files. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (8)📓 Common learnings📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
📚 Learning: 2025-11-27T16:27:35.304ZApplied to files:
🪛 LanguageTooldocs/github-actions.mdx[grammar] ~141-~141: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
|
@claude review this please, don't make any edits |
|
Claude finished @nicktrn's task in 1m 2s —— View job Review Complete
SummaryThis PR simplifies the self-hosting deployment documentation, removing deprecated CLI flags and streamlining the instructions. The changes are well-structured and improve clarity. Changes Reviewed
Review NotesLooks good overall. The documentation is now simpler and easier to follow for self-hosters. A few observations:
VerdictApprove - The changes correctly simplify the self-hosting documentation and remove deprecated CLI flags. The documentation is accurate and the cross-references are valid. | |
Fixes #2835
There were still some flags in here we removed, deploying is a lot simpler now for self-hosters.
Also updates the github actions guide.