Skip to content

change linking behavior #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a10y merged 1 commit into from
Feb 23, 2026
Merged

change linking behavior #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const ICON_SUN = `<svg xmlns="http://www.w3.org/2000/svg" width="18" height="18"

const ICON_MOON = `<svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M12 3a6 6 0 0 0 9 9 9 9 0 1 1-9-9Z"/></svg>`;

const ICON_EXTERNAL = `<svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M7 7h10v10"/><path d="M7 17 17 7"/></svg>`;

const TOGGLE_SCRIPT = `
function toggleTheme() {
const root = document.documentElement;
Expand Down Expand Up @@ -176,27 +178,27 @@ function rfcPage(rfc: RFC, repoUrl: string | null, liveReload: boolean = false):

// Accepted date
if (rfc.git.accepted) {
const acceptedLink = repoUrl
? `<a href="${repoUrl}/commit/${rfc.git.accepted.hash}" class="commit-link">${formatDate(rfc.git.accepted.date)}</a>`
: formatDate(rfc.git.accepted.date);
const commitLink = repoUrl
? ` <a href="${repoUrl}/commit/${rfc.git.accepted.hash}" class="commit-link" title="View commit">${ICON_EXTERNAL}</a>`
: "";

gitHeader += `
<div class="rfc-meta-item">
<span class="rfc-meta-label">Accepted:</span>
${acceptedLink}
<span class="rfc-meta-value">${formatDate(rfc.git.accepted.date)}${commitLink}</span>
</div>`;
}

// Last updated date
if (rfc.git.lastUpdated) {
const updatedLink = repoUrl
? `<a href="${repoUrl}/commit/${rfc.git.lastUpdated.hash}" class="commit-link">${formatDate(rfc.git.lastUpdated.date)}</a>`
: formatDate(rfc.git.lastUpdated.date);
const commitLink = repoUrl
? ` <a href="${repoUrl}/commit/${rfc.git.lastUpdated.hash}" class="commit-link" title="View commit">${ICON_EXTERNAL}</a>`
: "";

gitHeader += `
<div class="rfc-meta-item">
<span class="rfc-meta-label">Last updated:</span>
${updatedLink}
<span class="rfc-meta-value">${formatDate(rfc.git.lastUpdated.date)}${commitLink}</span>
</div>`;
}

Expand Down
18 changes: 17 additions & 1 deletion styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,13 +342,29 @@ th {
color: var(--fg-muted);
}

.rfc-meta-value {
display: inline-flex;
align-items: center;
gap: 0.375rem;
}

.commit-link {
display: inline-flex;
align-items: center;
color: var(--link);
}

.commit-link:hover {
color: var(--link-hover);
text-decoration: underline;
}

.commit-link svg {
display: block;
transition: stroke-width 0.1s ease;
}

.commit-link:hover svg {
stroke-width: 2.5;
}

.rfc-author {
Expand Down