Open
Conversation
By the spec here [1], it seems `[EnforceRange] required *` should be replaced by `required [EnforceRange] *`. [1] https://webidl.spec.whatwg.org/#extended-attributes-applicable-to-types
Collaborator
|
Looks correct, but the IDL parser chokes on the correct syntax. I filed plinss/widlparser#70 for this. |
Member
|
Does it really choke? The spec had Edit: And the diff is properly generated, so I don't think there's any blocker here. |
Collaborator
|
I double-checked, this is a bikeshed issue it seems like. It's when we attempt to describe the attribute that it fails: This fails like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the spec here [1], it seems
[EnforceRange] required *should bereplaced by
required [EnforceRange] *.[1] https://webidl.spec.whatwg.org/#extended-attributes-applicable-to-types
Preview | Diff