fix: avoid creating empty diff folders when no visual differences exist#1123
Merged
wswebcreation merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
…st (#879) The diff directory was eagerly created by `prepareComparisonFilePaths` via `getAndCreatePath` before any comparison took place. This resulted in empty diff folder trees even when tests passed or baselines were auto-saved. Extract a new `getPath` function that resolves the folder path without calling `mkdirSync`. Use it for the diff folder in `prepareComparisonFilePaths` so the directory is only created on disk when `saveBase64Image` actually writes a diff image. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: da01583 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #879
getPathhelper that resolves folder paths without creating them on disk, separating path computation from directory creationprepareComparisonFilePathsto usegetPathfor the diff folder instead ofgetAndCreatePath, so the diff directory is only created whensaveBase64Imageactually writes a diff imagegetPathandprepareComparisonFilePathsto verify that diff folders are not eagerly created