[explainer] Remove toolparamname attribute#125
Closed
andruud wants to merge 1 commit intowebmachinelearning:declarative-api-explainerfrom
Closed
[explainer] Remove toolparamname attribute#125andruud wants to merge 1 commit intowebmachinelearning:declarative-api-explainerfrom
andruud wants to merge 1 commit intowebmachinelearning:declarative-api-explainerfrom
Conversation
We should likely use the standard "name" attribute here, and just drop the `toolparamname` attribute. At the very least, the input elements in the example should *also* have a `name` attribute to be more realistic. Also fix some typos/mistakes.
Author
|
cc @domfarolino; looks like I can't set assignees/reviewers here. |
domfarolino
force-pushed
the
declarative-api-explainer
branch
from
01414c2 to
52143d7
Compare
Collaborator
|
Thanks! See #76 (comment) for how this got incorporated into the base PR—will give git co-author credit over there, and close this PR to streamline things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should likely use the standard
nameattribute here, and just drop thetoolparamnameattribute. At the very least, the input elements in the example should also have anameattribute to be more realistic.Also fix some typos/mistakes.