fix: never proxy hot-reload websocket requests#4316
Open
ajhyndman wants to merge 1 commit intowebpack:mainfrom
Open
fix: never proxy hot-reload websocket requests#4316ajhyndman wants to merge 1 commit intowebpack:mainfrom
ajhyndman wants to merge 1 commit intowebpack:mainfrom
Conversation
Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server. vuejs/vue-cli@72ba750 facebook/create-react-app#7444
ajhyndman
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
|
|
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Can you add test case and fix types?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Please let me know what kind of test could be appropriate for this change.
Motivation / Use-Case
Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.
vuejs/vue-cli@72ba750
facebook/create-react-app#7444