Open
Conversation
kojo1
reviewed
Dec 14, 2022
cconlon
requested changes
Mar 17, 2023
tls/client-tls-http.c
Outdated
| /* Connect to wolfSSL on the server side */ | ||
| if ((ret = wolfSSL_connect(ssl)) != SSL_SUCCESS) { | ||
| fprintf(stderr, "ERROR: failed to connect to wolfSSL\n"); | ||
| printf("%d\n",ret); |
Member
There was a problem hiding this comment.
Not sure we need this printf for ret. On failure, wolfSSL_connect will just return SSL_FAILURE. If you want to print the specific error, please call wolfSSL_get_error(ssl, ret), then print out the return of that function.
Contributor
Author
There was a problem hiding this comment.
Deleted unnecessary debug printf at 446f0a7.
Contributor
Author
|
kojo1
approved these changes
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.