Open
Conversation
This commit leaned heavily on Claude.
JacobBarthelmeh
requested changes
Jan 30, 2026
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Lots of build warnings:
bash-3.2$ make
gcc -o mcast-peer mcast-peer.c -Wall -Wextra -Os -lwolfssl -lm -lpthread
mcast-peer.c:186:9: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^
mcast-peer.c:188:9: warning: unused variable 'txSd' [-Wunused-variable]
int txSd = -1;
^
mcast-peer.c:189:9: warning: unused variable 'rxSd' [-Wunused-variable]
int rxSd = -1;
^
mcast-peer.c:190:18: warning: unused variable 'ctx' [-Wunused-variable]
WOLFSSL_CTX* ctx = NULL;
^
mcast-peer.c:191:14: warning: unused variable 'sslTx' [-Wunused-variable]
WOLFSSL* sslTx = NULL;
^
mcast-peer.c:192:14: warning: unused variable 'sslRx' [-Wunused-variable]
WOLFSSL* sslRx = NULL;
^
mcast-peer.c:193:24: warning: unused variable 'txAddr' [-Wunused-variable]
struct sockaddr_in txAddr;
^
mcast-peer.c:194:9: warning: unused variable 'i' [-Wunused-variable]
int i;
^
mcast-peer.c:197:19: warning: unused variable 'pms' [-Wunused-variable]
unsigned char pms[PMS_SIZE];
^
mcast-peer.c:198:19: warning: unused variable 'clientRandom' [-Wunused-variable]
unsigned char clientRandom[RANDOM_SIZE];
^
mcast-peer.c:199:19: warning: unused variable 'serverRandom' [-Wunused-variable]
unsigned char serverRandom[RANDOM_SIZE];
^
mcast-peer.c:201:19: warning: unused variable 'suite' [-Wunused-variable]
unsigned char suite[2] = { 0x00, 0xFE };
^
mcast-peer.c:203:12: warning: unused variable 'lastSend' [-Wunused-variable]
time_t lastSend = 0;
^
mcast-peer.c:204:9: warning: unused variable 'msgCount' [-Wunused-variable]
int msgCount = 0;
^
mcast-peer.c:76:12: warning: unused function 'setup_tx_socket' [-Wunused-function]
static int setup_tx_socket(struct sockaddr_in* txAddr)
^
mcast-peer.c:121:12: warning: unused function 'setup_rx_socket' [-Wunused-function]
static int setup_rx_socket(void)
^
16 warnings generated.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
requested changes
Feb 6, 2026
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Does this currently build for you? Am seeing the error:
bash-3.2$ cd dtls-mcast/
bash-3.2$ make clean
rm -f mcast-peer
bash-3.2$ make
gcc -o mcast-peer mcast-peer.c -Wall -I/usr/local/include -L/usr/local/lib -lwolfssl -lm
mcast-peer.c:67:30: error: cannot combine with previous 'type-name' declaration specifier
static volatile sig_atomic_t int running = 1;
^
1 error generated.
make: *** [mcast-peer] Error 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit leaned heavily on Claude.