libworkbench: implement GLogWriterFunc and library initialization#374
Open
andyholmes wants to merge 1 commit intomainfrom
Open
libworkbench: implement GLogWriterFunc and library initialization#374andyholmes wants to merge 1 commit intomainfrom
andyholmes wants to merge 1 commit intomainfrom
Conversation
sonnyp
reviewed
Aug 20, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Can you add the rational / benefit of this in the PR description?
andyholmes
force-pushed
the
andyholmes/libworkbench
branch
4 times, most recently
from
34287c9 to
71c18cb
Compare
Add `Workbench.init()` to initialize resources and other setup tasks. Currently, this only implements a `GLogWriterFunc` for silencing specific messages that Workbench users shouldn't see. This method has some limitations running on other threads in GJS, and should be more performant in C anyways.
andyholmes
force-pushed
the
andyholmes/libworkbench
branch
from
71c18cb to
eae9ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Workbench.init()to initialize resources and other setup tasks.Currently, this only implements a
GLogWriterFuncfor silencingspecific messages that Workbench users shouldn't see.
This method has some limitations running on other threads in GJS,
and should be more performant in C anyways.