Fix test_strwidth() ICU version-dependent behavior for Devanagari conjuncts#189
Merged
swissspidy merged 3 commits intomasterfrom Dec 12, 2025
Merged
Fix test_strwidth() ICU version-dependent behavior for Devanagari conjuncts#189swissspidy merged 3 commits intomasterfrom
swissspidy merged 3 commits intomasterfrom
Conversation
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unexpected test failure in test_strwidth
Fix test_strwidth() ICU version-dependent behavior for Devanagari conjuncts
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_strwidth()test was skipped due to failures in CI environments with modern ICU versions (54.1+). ICU'sgrapheme_strlen()treats Devanagari conjuncts (consonant + virama + consonant) as single graphemes, while PCRE's\Xtreats them as separate clusters.Changes
markTestSkipped()callExample
Both behaviors are correct for their respective purposes: ICU for linguistic grapheme counting, PCRE for visual width calculation.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.