Switch from pyzstd to compression.zstd#818
Switch from pyzstd to compression.zstd#818avalentino wants to merge 1 commit intozarr-developers:mainfrom
Conversation
Python v3.14 introduces the `compression.zstd` module (derived from pyzsrd). For Python versions lower than v3.14 the `backports.zstd` module is now available. This patch modifies teh test code to use `compression.zsrd` intead of the old and deprecated `pyzstd` module.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (2.14%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
==========================================
- Coverage 99.33% 2.14% -97.19%
==========================================
Files 26 26
Lines 898 884 -14
==========================================
- Hits 892 19 -873
- Misses 6 865 +859 🚀 New features to boost your workflow:
|
|
Failures seem to be unrelated to this PR. |
|
@avalentino are you using zstd in the context of Zarr? because if so, would you mind opening a PR to make this change in zarr-python, which would allow us to no longer depend on numcodecs for zstd in that library? |
|
the context is, putting codec implementations in a separate library only makes sense when they require special dependencies. If a zstd codec can be implemented in zarr-python directly via simple dependencies (like a backport), then we don't really need numcodecs in the loop for that codec |
|
I didn't look at the code yet but it seems reasonable to me. |
[Description of PR]
Python v3.14 introduces the
compression.zstdmodule (derived from pyzsrd).For Python versions lower than v3.14 the
backports.zstdmodule is now available.This patch modifies teh test code to use
compression.zsrdintead of the old and deprecatedpyzstdmodule.TODO: