fix(server): harden RPC $transaction handler correctness#2404
Closed
fix(server): harden RPC $transaction handler correctness#2404
Conversation
…rations and validation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add transaction handling with sequential operations and validation
fix(server): harden RPC $transaction handler correctness
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several correctness issues in the
handleTransactionRPC handler surfaced in review.Changes:
sequential) intohandleTransactionand return 400 for any unrecognised type, preventing silent acceptance of typo'd routes like/$transaction/foobarargsthroughprocessRequestPayloadbefore invoking the ORM, so BigInt/Date/Bytes fields encoded withmeta.serializationare correctly deserialized (same pipeline as regular RPC operations)try— build the promise array inside thetryblock so that a missing/undefined model operation (e.g. invalidopname) throws into the error handler rather than crashing unguarded; additionally tighten theargsvalidation to reject arraysVALID_OPShoisted to module scope — replaced the hardcoded per-callSetwithnew Set(CoreCrudOperations)at module level to avoid redundancy and stay in sync with the canonical operation listdeleteManycleanup intobeforeEach/afterEachwithin thedescribe('transaction')block to eliminate repeated inline teardownExample — before (args bypass deserialization):
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.